Skip to content
This repository was archived by the owner on Feb 18, 2024. It is now read-only.

Add videogular#726

Open
whitneyit wants to merge 1 commit intojspm:masterfrom
whitneyit:master
Open

Add videogular#726
whitneyit wants to merge 1 commit intojspm:masterfrom
whitneyit:master

Conversation

@whitneyit
Copy link
Copy Markdown
Contributor

@guybedford
Copy link
Copy Markdown
Member

Is it not possible to use the npm version?

@whitneyit
Copy link
Copy Markdown
Contributor Author

It should be able to. I just defaulted to github our of habbit 😄

@guybedford
Copy link
Copy Markdown
Member

Sure it's generally preferred and will come with things like format: 'cjs' by default.

@whitneyit
Copy link
Copy Markdown
Contributor Author

Do you want me to remove the format then?

@whitneyit
Copy link
Copy Markdown
Contributor Author

Also, will this download and install the required dependencies?

@guybedford
Copy link
Copy Markdown
Member

Yes it will need to be tested separately as there are different behaviours for npm packages.

@whitneyit
Copy link
Copy Markdown
Contributor Author

I ask because the package.json doesn't contain any reference to angular or angular-sanitize

@guybedford
Copy link
Copy Markdown
Member

Yes they would need to be added as dependencies.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants