fix GenericStack.pop() and modify toString()#45
Open
r3gor wants to merge 1 commit intojsquared21:masterfrom
Open
fix GenericStack.pop() and modify toString()#45r3gor wants to merge 1 commit intojsquared21:masterfrom
r3gor wants to merge 1 commit intojsquared21:masterfrom
Conversation
1. Call list[size] should return null (if list[size-1] is the last element of the stack), this does not happen because the pop() method does not actually eliminate any element. 2. When pop() is called, size should never be left with a negative value.
r3gor
force-pushed
the
master
branch
2 times, most recently
from
5d85824 to
6245273
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Call
list[size]should returnnull(iflist[size-1]is the last element of the stack), this does not happen because thepop()method does not actually eliminate any element.When
pop()is called,sizeshould never be left with a negative value.