Check maximum iterations in sglfit.#14
Open
jonlachmann wants to merge 1 commit intojstriaukas:masterfrom
Open
Conversation
…nt descent to avoid getting stuck.
Owner
|
I agree — will do. |
Author
|
@jstriaukas Did you find time to look at this? Best, Jon |
Owner
|
not yet. I will update the whole package sometime in Spring. Thanks
…On Mon, 8 Jan 2024 at 12:47, jonlachmann ***@***.***> wrote:
@jstriaukas <https://github.com/jstriaukas> Did you find time to look at
this? Best, Jon
—
Reply to this email directly, view it on GitHub
<#14 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AFAD4IBSC7MB7BSG2NJC6ILYNPFF5AVCNFSM6AAAAAA5HMAONOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOBQG43DKNZQGI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
--
*Jonas Striaukas*
Assistant Professor of Statistics
Department of Finance
Copenhagen Business School
https://jstriaukas.github.io/
|
Author
|
@jstriaukas Just wanted to send a ping to see if you have had any time to look at this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add check for maximum iterations in proximal coordinate descent and gradient descent to avoid getting stuck.