Merged
Conversation
… when a file is already downloaded locally
- fix path to new location of sp3.evaluate - minor modifications
… file - rewrote tests - bug corrections (multi-day)
- Work with Path rather than file name (str)
Collaborator
|
I observed that the tests were quite long, which was explained by different things:
I changed many things in the module, and mainly:
And then I rewrote almost all tests, simplifying the test cases. @eulaliesa, you can have a look at the changes between 1534cbe and 3541dac to see those changes. It may feel like I rewrote almost all what you did, but in reality, I could not have done this without your code and our discussions. So thanks a lot! |
Collaborator
|
I still have to merge main into this branch. Will do this later... |
# Conflicts: # src/prx/rinex_nav/evaluate.py # src/prx/rinex_nav/test/test_evaluate.py # src/prx/test/test_main.py
Collaborator
|
@jtec, let's merge this one. |
jtec
reviewed
Feb 4, 2026
jtec
reviewed
Feb 4, 2026
Owner
|
Some of the test .CLK files are a few Mb, is there a way to make the tests fewer files or truncate the files if not their entire content is needed? And/or compress them or use git LFS for them? |
jtec
approved these changes
Feb 4, 2026
- include reviewer's comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This branch introduces a mechanism to retrieve SP3 and CLK files.
The logic follows a two-step approach:
Local Search:
The system first attempts to find the required SP3 and CLK files locally (e.g. in a pre-downloaded database or directory).
Remote Download with Priority:
If the files are not available locally, it proceeds to download them automatically from known public sources, following a priority list of analysis centers and product types.
Final (
FIN) products are preferred over rapid (RAP) ones, and centers like COD, GRG, and GFZ are prioritized due to their reliability and precision./mgexsubfolder, requiring different path logic during discovery.