Conversation
One to do regular checks, one does trusted publishes on git tags
|
Hey @JadedBlueEyes, thanks so much for contributing. On Bluesky, you mentioned you were having a problem using the packages with I ran the build process locally and noticed the resulting TypeScript declaration files appear to be the same as the source files, and the resulting ESM & CJS files are empty because there is no runtime code. In the interest of simplicity, I'm wondering whether the added build steps and CI are strictly necessary at the moment. Would it be possible to reduce the scope of this PR to just the There may be a gap in my knowledge around shipping types to npm, apologies if so 🙂. |
|
So the issue was specifically with importing types without using the Everything necessary for that is included in the first commit - JadedBlueEyes@30e7e83 - which is around 150loc changed excluding the lock file. The CI workflows aren't strictly necessary, but the checks one is useful to know if formatting is correct, and types are valid, etc - and the publish one is needed to do trusted publishing, which shows that no malicious code has been injected before publishing and the code exactly matches what's in git:
|

Most of this is lifted from my other projects. I haven't been able to test the trusted publishing workflow as I use pnpm, but it should work.