fix: offer signatures for methods with no positional arguments#144
Merged
Conversation
Signature help filtered candidate signatures with `length(s.parameters) > arg`, but `parameters` holds only positional parameters. At the first argument position (`arg == 0`) this dropped every method with zero positional parameters, so a keyword-only method like `bar(; x)` was skipped and a sole `baz(; x)` produced no popup at all. At the first position nothing is committed yet, so keep all methods as candidates; narrowing by positional arity still applies once the cursor moves past the first argument. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signature help filtered candidate signatures with
length(s.parameters) > arg, butparametersholds only positional parameters. At the first argument position (arg == 0) this dropped every method with zero positional parameters, so a keyword-only method likebar(; x)was skipped and a solebaz(; x)produced no popup at all.At the first position nothing is committed yet, so keep all methods as candidates; narrowing by positional arity still applies once the cursor moves past the first argument.
Fixes julia-vscode/LanguageServer.jl#1367.