feat: distinguish uncacheable declared deps from unknown imports#146
Merged
Conversation
An `UnresolvedImport` on a name the project declares as a dependency (`regular_packages` / `stdlib_packages` / `deved_packages`) now reports that the dependency's symbols could not be indexed/cached, rather than the generic "Failed to resolve" used for names that aren't in the environment at all (typo or missing dependency). The consequence clause (wildcard vs explicit) is unchanged, so existing messages for undeclared names are preserved. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-lands #135, which merged into the
sp/unresolved-import-missing-refsfeature branch after that branch had already reachedmain(via #133), so its change never landed onmain. Same commit, now targetingmaindirectly.An
UnresolvedImporton a name the project declares as a dependency (regular_packages/stdlib_packages/deved_packages) now reports that the dependency's symbols could not be indexed/cached, rather than the generic "Failed to resolve" used for names that aren't in the environment at all (typo or missing dependency). The consequence clause (wildcard vs explicit) is unchanged, so existing messages for undeclared names are preserved.