Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
|
||
| // Format the baseDomain as "namespace.apps.openShiftBaseDomain" | ||
| // This matches the Helm template behavior when .noNs is false | ||
| detectedBaseDomain := fmt.Sprintf("%s.apps.%s", namespace, openShiftBaseDomain) |
There was a problem hiding this comment.
I think using apps.<baseDomain> works for most OpenShift clusters, but since the domain can be customized by admins, it might be safer to read it from the cluster’s ingress configuration instead of using hardcoded value, wdyt?
There was a problem hiding this comment.
Right, that would make sense 👍 I need to check where that ingress configuration lives :)
|
@mangelajo @bennyz #204 merged, serving a similar goal. I think we can close this one. |
yes, closing. Thank you!! :) |
depends on #177