This repository was archived by the owner on Jan 22, 2026. It is now read-only.
Add support for requesting a lease by device name directly#34
Draft
bkhizgiy wants to merge 1 commit intojumpstarter-dev:mainfrom
Draft
Add support for requesting a lease by device name directly#34bkhizgiy wants to merge 1 commit intojumpstarter-dev:mainfrom
bkhizgiy wants to merge 1 commit intojumpstarter-dev:mainfrom
Conversation
Signed-off-by: Bella Khizgiyaev <bkhizgiy@redhat.com>
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the single selector field with a oneof exporter_selection, allowing leases to target either exporters via label selector or a specific device by resource name.
Both options are immutable to preserve lease semantics.
The field is no longer marked as REQUIRED, as the controller now validates whether a value was provided.
Issue: https://github.com/jumpstarter-dev/jumpstarter/issues/638
Related to: jumpstarter-dev/jumpstarter-controller#208