This repository was archived by the owner on Jan 23, 2026. It is now read-only.
[Backport release-0.7] driver-ssh: SSHWrapperClient.run return stdout and stderr#784
Merged
mangelajo merged 3 commits intorelease-0.7from Dec 22, 2025
Merged
Conversation
Add SSHCommandExecResult to wrap the subprocess SSH command return and use it as return type for SSHWrapperClient.run, so that the output of the command can be inspected after the call. Signed-off-by: Albert Esteve <aesteve@redhat.com> (cherry picked from commit 20d48c4)
Add SSHCommandRunOptions class and modify the run method signature to use it. This will make it easier to change the options before having to change the signature in the future. Signed-off-by: Albert Esteve <aesteve@redhat.com> (cherry picked from commit 9b4e636)
Change logging formatting to use %-formatting so that formatting is deferred until the log is printed [1]. [1] https://pylint.readthedocs.io/en/latest/user_guide/messages/warning/logging-fstring-interpolation.html Signed-off-by: Albert Esteve <aesteve@redhat.com> (cherry picked from commit 627d1fc)
Contributor
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the Comment |
mangelajo
approved these changes
Dec 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bot-based backport to
release-0.7, triggered by a label in #748.