Adapt assistant rules to new format, and add CLAUDE.md#107
Conversation
Creates .claude/rules/ directory with symlinks to existing .cursor/rules/ files, enabling both Cursor and Claude Code users to share the same project guidelines without duplication. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
📝 WalkthroughWalkthroughReorganizes Python workspace under a new Changes
Sequence Diagram(s)(omitted — changes are documentation and a local scaffolding script update; no multi-component runtime flow requiring visualization) Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
python/__templates__/create_driver.sh (1)
26-33: Replacesed_cmdvariable with a function to fix macOS compatibility.The
sed_cmd="sed -i ''"assignment on line 30 fails when expanded as a variable on macOS. Variable word splitting loses the empty string argument, causing sed to misinterpret the pattern as a filename. This works on Linux (sed -i) but breaks on macOS (sed -i '').Use a function instead to preserve argument boundaries:
Fix
# MacOS has a different syntax for sed -i, we either use gsed (GNU sed) or apply the right -i syntax if command -v gsed &> /dev/null; then - sed_cmd="gsed" -elif [[ "$(uname)" == "Darwin" ]]; then - sed_cmd="sed -i ''" -else - sed_cmd="sed -i" -fi + sed_inplace() { gsed -i "$@"; } +elif [[ "$(uname)" == "Darwin" ]]; then + sed_inplace() { sed -i '' "$@"; } +else + sed_inplace() { sed -i "$@"; } +fiThen on line 81, replace
$sed_cmd "s/..."withsed_inplace "s/...".
Documents the development workflow for modifying the Jumpstarter operator, including CRD type changes, controller logic, testing, and common issues.
0c9c8ef to
757adda
Compare
There was a problem hiding this comment.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
.cursor/rules/creating-new-drivers.mdc (1)
41-47: Fix the test command typo to match repo conventions.Line 47 uses
make pkg-test-<driver_package>, but the documented convention in this repo ismake test-pkg-<driver_package>(ormake test). This mismatch will cause users to run a non-existent target. As per learnings, align the command.🔧 Proposed fix
-6. Test the driver: `make pkg-test-<driver_package>` +6. Test the driver: `make test-pkg-<driver_package>`
There was a problem hiding this comment.
so this is the main change here.. looks good to me, however let's wait for @kirkbrauer opinion
kirkbrauer
left a comment
There was a problem hiding this comment.
This looks good, if it is working well for you guys then I think we should be good to go!
Summary by CodeRabbit
Documentation
Improvements
Project Structure
✏️ Tip: You can customize this high-level summary in your review settings.