Conversation
📝 WalkthroughWalkthroughAdds a new public Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Important Action Needed: IP Allowlist UpdateIf your organization protects your Git platform with IP whitelisting, please add the new CodeRabbit IP address to your allowlist:
Reviews will stop working after February 8, 2026 if the new IP is not added to your allowlist. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
971cf1f to
77f7f7c
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In @.github/workflows/python-tests.yaml:
- Around line 32-36: The paths-filter action uses a static base value that can
cause empty diffs on push; change the base input to use the pre-push commit SHA
for push events by referencing github.event.before instead of defaulting to
'main' (i.e., update the base key used by dorny/paths-filter), so that the
action compares changes against the pre-push state and the existing python
filters (python: - 'python/**' - '.github/workflows/python-tests.yaml') are
evaluated correctly.
77f7f7c to
be498ae
Compare
|
rebased |
This maintains the ability to create depending PRs on existing PRs and have the CI run on them.
evakhoni
left a comment
There was a problem hiding this comment.
so basically running dorny/paths-filter and then deciding based on it's results..
the only thing i can think about is what coderabbit already commented, so let's merge this one, and worst case we can follow up if an issue is actually observed.
General workflow level skips don't work for github if you make PRs depending on any jobs from the workflow, the PR just keeps waiting and the job never shows up, this is a know limitation of github today.
The alternative that seems to work is to make individual jobs skipped based on rules, like in this case the detection of files being modified or not, this will make the job show as "skipped" and then it's ok that you add a rule to require the job for merging, when the job shows at skipped that is good enough for you to be able to merge the PR.
The intent of this PR is to optimize the usage of CI resources and the noise/clutter of too many CI runs.
Summary by CodeRabbit