Add Locale conversion format configuration property#3410
Add Locale conversion format configuration property#3410scordio wants to merge 1 commit intojunit-team:mainfrom
Locale conversion format configuration property#3410Conversation
| * | ||
| * @since 5.11 | ||
| */ | ||
| @API(status = INTERNAL, since = "5.11") |
There was a problem hiding this comment.
Is it correct to mark this as an internal API as the users are supposed to set these values in the config property only and not rely on the enum?
scordio
force-pushed
the
locale_conversion_config_property
branch
from
abfc72b to
95da5f8
Compare
scordio
changed the title
Locale conversion format configuration property
scordio
force-pushed
the
locale_conversion_config_property
branch
from
95da5f8 to
f833690
Compare
|
Waiting for #3507 to be finalized before moving forward. |
|
@scordio Are you still interested in continuing with this PR? |
|
Yes! This has fallen under my radar... thanks for the reminder 🙂 I'll rebase it and catch up with the missing parts in the upcoming weeks. |
scordio
force-pushed
the
locale_conversion_config_property
branch
from
f833690 to
85434d2
Compare
This comment was marked as outdated.
This comment was marked as outdated.
|
@marcphilipp based on what you mentioned at #4246 (comment), should we resurrect this PR despite #4219? |
|
Yes, I think we should! 👍 I couldn't reopen it, though, since you have already deleted the underlying branch. Would you like to restore it or rather start a new PR? |
|
Although I still have the branch locally, I couldn't trick GitHub to reopen this PR 😅 I'll start fresh then! |
|
Superseded by #4492. |
2 participants
Overview
Fixes #3141.
I hereby agree to the terms of the JUnit Contributor License Agreement.
Definition of Done
@APIannotations