Make Kotlin suspend function checks ClassLoader-agnostic#5373
Open
geoand wants to merge 1 commit intojunit-team:mainfrom
Open
Make Kotlin suspend function checks ClassLoader-agnostic#5373geoand wants to merge 1 commit intojunit-team:mainfrom
ClassLoader-agnostic#5373geoand wants to merge 1 commit intojunit-team:mainfrom
Conversation
This is done because with the current version of the code, in order for a method to consider a Kotlin suspending method, Kotlin and the test class need to be loaded from the same ClassLoader, but in Quarkus that is not the case Relates to: quarkusio/quarkus#52480 Signed-off-by: Georgios Andrianakis <geoand@gmail.com>
geoand
force-pushed
the
quarkus-#52480
branch
from
a39b6c1 to
dc8d694
Compare
sbrannen
changed the title
ClassLoader-agnostic
Member
|
@geoand Have you verified that this change solves the issue on the Quarkus side? |
Author
|
I've verified that it gets me past the JUnit part and on to the part we have to fix eventually in Quarkus |
Member
|
Let's take a step back and start with an issue and a (minimal) reproducer so we can ensure we fully understand the problem before discussing a potential solution. @geoand Could you please create an issue and supply a reproducer? |
Author
|
Of course! I opened #5375 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This is done because with the current version of the code, in order for a method to be considered a Kotlin suspending method, Kotlin and the test class need to be loaded from the same
ClassLoader, but in Quarkus that is not the case.Related Issues
@QuarkusTestignores Kotlinsuspendtest methods quarkusio/quarkus#52480I hereby agree to the terms of the JUnit Contributor License Agreement.