Skip to content

feat: support rsa signature #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
junkurihara merged 7 commits into from
Feb 13, 2026
Merged

feat: support rsa signature #12

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
6eeef5f
feat: support rsassa-pkcs-v1.5-sha256 and rsassa-pss-sha512, braking …
junkurihara Feb 13, 2026
b3e9173
update docs
junkurihara Feb 13, 2026
ea8a07e
chore: remove rsasig feature from the default
junkurihara Feb 13, 2026
f85034e
fix: update api signature of get_alg_key_ids
junkurihara Feb 13, 2026
c5e161d
fix: fix inner process of get_alg_key_ids
junkurihara Feb 13, 2026
1a9aa42
refactor: update several internal processes
junkurihara Feb 13, 2026
2b0ab65
chore: make rsa-signature non-default
junkurihara Feb 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ resolver = "2"

[workspace.package]
edition = "2021"
version = "0.0.21"
version = "0.0.22"
authors = ["Jun Kurihara"]
homepage = "https://github.com/junkurihara/httpsig-rs"
repository = "https://github.com/junkurihara/httpsig-rs"
Expand Down
32 changes: 22 additions & 10 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,13 +16,11 @@ This crates provides a basic library [httpsig](./httpsig) and [its extension](./
- [x] HMAC using SHA-256
- [x] Ed25519
- [x] ECDSA-P256 using SHA-256
- [ ] ECDSA-P384 using SHA-384
- [x] ECDSA-P384 using SHA-384
- [x] RSASSA-PSS using SHA-512
- [x] RSASSA-PKCS1-v1_5 using SHA-256

~~- [ ] RSASSA-PSS using SHA-512~~

~~- [ ] RSASSA-PKCS1-v1_5 using SHA-256~~

At this point, we have no plan to support RSA signature due to [the problem related to the non-constant time operation](https://github.com/RustCrypto/RSA/issues/19), i.e., [Mervin Attack](https://people.redhat.com/~hkario/marvin/).
At this point, **RSA signature is non-default** due to [the problem related to the non-constant time operation](https://github.com/RustCrypto/RSA/issues/19), i.e., [Marvin Attack](https://people.redhat.com/~hkario/marvin/). If you want to use RSA signature, please enable the `rsa-signature` feature flag in your `Cargo.toml`.

## Usage of Extension for `hyper` (`httpsig-hyper`)

Expand All @@ -48,8 +46,11 @@ async fn signer<B>(&mut req: Request<B>) -> HttpSigResult<()> {
.unwrap();
let mut signature_params = HttpSignatureParams::try_new(&covered_components).unwrap();

// specify algorithm name since we cannot always infer it from key info
let alg = AlgorithmName::Ed25519;

// set signing/verifying key information, alg and keyid
let secret_key = SecretKey::from_pem(SECRET_KEY_STRING).unwrap();
let secret_key = SecretKey::from_pem(&alg, SECRET_KEY_STRING).unwrap();
signature_params.set_key_info(&secret_key);

req
Expand All @@ -59,7 +60,11 @@ async fn signer<B>(&mut req: Request<B>) -> HttpSigResult<()> {

/// Validation function that verifies a request with a signature
async fn verifier<B>(req: &Request<B>) -> HttpSigResult<SignatureName> {
let public_key = PublicKey::from_pem(PUBLIC_KEY_STRING).unwrap();
// specify algorithm name since we cannot always infer it from key info
let alg = AlgorithmName::Ed25519; // directly use Ed25519 algorithm
// or else infer it from the request. Find your public key from IndexMap with alg and key_id pairs
// let alg_key_id_map = req.get_alg_key_ids().unwrap();
let public_key = PublicKey::from_pem(&alg, PUBLIC_KEY_STRING).unwrap();
let key_id = public_key.key_id();

// verify signature with checking key_id
Expand Down Expand Up @@ -105,8 +110,11 @@ async fn signer<B>(&mut res: Response<B>, corresponding_req: &Request<B>) -> Htt
.unwrap();
let mut signature_params = HttpSignatureParams::try_new(&covered_components).unwrap();

// specify algorithm name since we cannot always infer it from key info
let alg = AlgorithmName::Ed25519;

// set signing/verifying key information, alg and keyid
let secret_key = SecretKey::from_pem(SECRET_KEY_STRING).unwrap();
let secret_key = SecretKey::from_pem(&alg, SECRET_KEY_STRING).unwrap();
signature_params.set_key_info(&secret_key);

req
Expand All @@ -116,7 +124,11 @@ async fn signer<B>(&mut res: Response<B>, corresponding_req: &Request<B>) -> Htt

/// Validation function that verifies a response with a signature from response itself and sent request
async fn verifier<B>(res: &Response<B>, sent_req: &Request<B>) -> HttpSigResult<SignatureName> {
let public_key = PublicKey::from_pem(PUBLIC_KEY_STRING).unwrap();
// specify algorithm name since we cannot always infer it from key info
let alg = AlgorithmName::Ed25519; // directly use Ed25519 algorithm
// or else infer it from the response. Find your public key from IndexMap with alg and key_id pairs
// let alg_key_id_map = res.get_alg_key_ids().unwrap();
let public_key = PublicKey::from_pem(&alg, PUBLIC_KEY_STRING).unwrap();
let key_id = public_key.key_id();

// verify signature with checking key_id
Expand Down
3 changes: 2 additions & 1 deletion httpsig-hyper/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,11 @@ rust-version.workspace = true
[features]
default = ["blocking"]
Copy link

Copilot AI Feb 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "rsa-signature" feature is enabled by default in httpsig-hyper, but the README explicitly states that "RSA signature is non-default due to the problem related to the non-constant time operation (Marvin Attack)". This is inconsistent - if RSA support should be opt-in for security reasons (as stated), then it should not be in the default features of httpsig-hyper. Consider removing "rsa-signature" from the default features to align with the stated security policy.

Copilot uses AI. Check for mistakes.
blocking = ["futures/executor"]
rsa-signature = ["httpsig/rsa-signature"]


[dependencies]
httpsig = { path = "../httpsig", version = "0.0.21" }
httpsig = { path = "../httpsig", version = "0.0.22" }

thiserror = { version = "2.0.18" }
tracing = { version = "0.1.44" }
Expand Down
3 changes: 2 additions & 1 deletion httpsig-hyper/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,8 @@ If you need to verify the body of a given message when `content-digest` is cover

```rust
// first verifies the signature according to `signature-input` header
let public_key = PublicKey::from_pem(EDDSA_PUBLIC_KEY).unwrap();
let alg = AlgorithmName::Ed25519;
let public_key = PublicKey::from_pem(&alg, EDDSA_PUBLIC_KEY).unwrap();
let signature_verification = req.verify_message_signature(&public_key, None).await;
assert!(verification_res.is_ok());

Expand Down
8 changes: 4 additions & 4 deletions httpsig-hyper/examples/hyper-request.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ async fn sender_ed25519(req: &mut Request<BoxBody>) {
let mut signature_params = HttpSignatureParams::try_new(&covered_components).unwrap();

// set signing/verifying key information, alg and keyid with ed25519
let secret_key = SecretKey::from_pem(EDDSA_SECRET_KEY).unwrap();
let secret_key = SecretKey::from_pem(&AlgorithmName::Ed25519, EDDSA_SECRET_KEY).unwrap();
signature_params.set_key_info(&secret_key);

// set signature with custom signature name
Expand All @@ -65,7 +65,7 @@ async fn sender_hs256(req: &mut Request<BoxBody>) {
let mut signature_params = HttpSignatureParams::try_new(&covered_components).unwrap();

// set signing/verifying key information, alg and keyid and random noce with hmac-sha256
let shared_key = SharedKey::from_base64(HMACSHA256_SECRET_KEY).unwrap();
let shared_key = SharedKey::from_base64(&AlgorithmName::HmacSha256, HMACSHA256_SECRET_KEY).unwrap();
signature_params.set_key_info(&shared_key);
signature_params.set_random_nonce();

Expand All @@ -81,7 +81,7 @@ where
B: http_body::Body + Send + Sync,
{
println!("Verifying ED25519 signature");
let public_key = PublicKey::from_pem(EDDSA_PUBLIC_KEY).unwrap();
let public_key = PublicKey::from_pem(&AlgorithmName::Ed25519, EDDSA_PUBLIC_KEY).unwrap();
let key_id = public_key.key_id();

// verify signature with checking key_id
Expand All @@ -94,7 +94,7 @@ where
B: http_body::Body + Send + Sync,
{
println!("Verifying HMAC-SHA256 signature");
let shared_key = SharedKey::from_base64(HMACSHA256_SECRET_KEY).unwrap();
let shared_key = SharedKey::from_base64(&AlgorithmName::HmacSha256, HMACSHA256_SECRET_KEY).unwrap();
let key_id = VerifyingKey::key_id(&shared_key);

// verify signature with checking key_id
Expand Down
8 changes: 4 additions & 4 deletions httpsig-hyper/examples/hyper-response.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ async fn sender_ed25519(res: &mut Response<BoxBody>, received_req: &Request<BoxB
let mut signature_params = HttpSignatureParams::try_new(&covered_components).unwrap();

// set signing/verifying key information, alg and keyid with ed25519
let secret_key = SecretKey::from_pem(EDDSA_SECRET_KEY).unwrap();
let secret_key = SecretKey::from_pem(&AlgorithmName::Ed25519, EDDSA_SECRET_KEY).unwrap();
signature_params.set_key_info(&secret_key);

// set signature with custom signature name
Expand All @@ -77,7 +77,7 @@ async fn sender_hs256(res: &mut Response<BoxBody>, received_req: &Request<BoxBod
let mut signature_params = HttpSignatureParams::try_new(&covered_components).unwrap();

// set signing/verifying key information, alg and keyid and random noce with hmac-sha256
let shared_key = SharedKey::from_base64(HMACSHA256_SECRET_KEY).unwrap();
let shared_key = SharedKey::from_base64(&AlgorithmName::HmacSha256, HMACSHA256_SECRET_KEY).unwrap();
signature_params.set_key_info(&shared_key);
signature_params.set_random_nonce();

Expand All @@ -93,7 +93,7 @@ where
B: http_body::Body + Send + Sync,
{
println!("Verifying ED25519 signature");
let public_key = PublicKey::from_pem(EDDSA_PUBLIC_KEY).unwrap();
let public_key = PublicKey::from_pem(&AlgorithmName::Ed25519, EDDSA_PUBLIC_KEY).unwrap();
let key_id = public_key.key_id();

// verify signature with checking key_id
Expand All @@ -106,7 +106,7 @@ where
B: http_body::Body + Send + Sync,
{
println!("Verifying HMAC-SHA256 signature");
let shared_key = SharedKey::from_base64(HMACSHA256_SECRET_KEY).unwrap();
let shared_key = SharedKey::from_base64(&AlgorithmName::HmacSha256, HMACSHA256_SECRET_KEY).unwrap();
let key_id = VerifyingKey::key_id(&shared_key);

// verify signature with checking key_id
Expand Down
Loading