Support legacy notebook launcher#48
Conversation
jupyterlab_pullrequests/__init__.py
Outdated
| log = server_app.log | ||
| config = PRConfig(config=server_app.config) | ||
| setup_handlers(server_app.web_app, config) | ||
| setup_handlers(server_app, config) |
There was a problem hiding this comment.
i don't think this is ready for that yet!
|
|
||
| # for legacy launching with notebok (e.g. Binder) | ||
| _jupyter_server_extension_paths = _jupyter_server_extension_points | ||
| load_jupyter_server_extension = _load_jupyter_server_extension |
There was a problem hiding this comment.
good start, there's also the json files that need to be deployed? or maybe we already do that...
There was a problem hiding this comment.
The JSON files were already well set. But this backport was missing
Codecov Report
@@ Coverage Diff @@
## master #48 +/- ##
=========================================
Coverage ? 61.02%
=========================================
Files ? 34
Lines ? 1647
Branches ? 94
=========================================
Hits ? 1005
Misses ? 637
Partials ? 5
Continue to review full report at Codecov.
|
fcollonval
left a comment
fcollonval
left a comment
There was a problem hiding this comment.
Thank you for fixing this one @bollwyvl
|
|
||
| # for legacy launching with notebok (e.g. Binder) | ||
| _jupyter_server_extension_paths = _jupyter_server_extension_points | ||
| load_jupyter_server_extension = _load_jupyter_server_extension |
There was a problem hiding this comment.
The JSON files were already well set. But this backport was missing
|
Cool thanks for cleaning up some of the unbundling. When next I get a
chance I'll merge into #44 and see what's still hanging out, maybe it can
actually land with the anonymous provider... Someday!
|
3 participants
Extracted from #44