ci: run lint, build and tests on every PR to release - #5
Open
murdore wants to merge 1 commit into
Open
Conversation
The 53-test suite only ran locally, so nothing stopped a regression from being merged — all three of the recent fix PRs were verified by hand. - pnpm pinned to 8.15.0 to match the packageManager field. - A global git identity is configured because the suite drives real git against temporary repositories. - vitest is invoked directly rather than through `pnpm test`, which would rebuild what the previous step just built. - A final pack check catches a broken `files` list or a missing build artifact before it could reach the registry.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 53-test suite only ran locally — nothing stopped a regression from being merged. All three recent fix PRs were verified by hand.
Runs on every PR to
releaseand on pushes torelease:pnpm run lintpnpm run buildpnpm exec vitest runnpm pack --dry-runNotes on the details:
packageManagerfield.gitagainst temporary repositories; runners have no identity, sogit commitin the fixtures would fail.pnpm test, which runs a build first and would redo the previous step.npm pack --dry-run, notpnpm pack --dry-run— pnpm 8.15 rejects that flag (ERROR Unknown option: 'dry-run'), verified locally. npm is on the runner regardless.concurrencycancels superseded runs on the same ref.Verified locally:
pnpm exec vitest run→ 53/53,pnpm run lint→ 0 errors,pnpm run buildclean.