fix(volume): 🐛 use overflow-safe arithmetic in bounds checks#100
Merged
justapithecus merged 2 commits intomainfrom Feb 7, 2026
Merged
fix(volume): 🐛 use overflow-safe arithmetic in bounds checks#100justapithecus merged 2 commits intomainfrom
justapithecus merged 2 commits intomainfrom
Conversation
Rewrite all `offset + length > limit` patterns as `length > limit - offset` to prevent silent int64 overflow when offset is near math.MaxInt64. Affects 5 locations: StageWriteAt, Commit, ReadAt, validateNoOverlaps, and validateVolumeManifest. Add 7 tests exercising near-MaxInt64 values across all affected code paths. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…heck The test asserts no overlap (non-overlapping blocks), so the name "Detected" was misleading. Comments also described block order backwards and mischaracterized the overflow risk as missed detection rather than false-positive detection. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
offset + length > limitpatterns aslength > limit - offsetto prevent silent int64 overflow when offset is nearmath.MaxInt64volume.go:StageWriteAt,Commit,ReadAt,validateNoOverlaps,validateVolumeManifestDetail
Go's int64 arithmetic wraps silently on overflow. A malformed
BlockRefwithOffset = math.MaxInt64 - 5, Length = 10would causeOffset + Lengthto wrap to a small positive number, passing the bounds checkoffset + length > totalLengthincorrectly.The fix rewrites each check as
length > totalLength - offset, which is overflow-safe because bothoffsetandtotalLengthare validated non-negative upstream.For
validateNoOverlaps, the overlap checkprevEnd > sorted[i].Offset(whereprevEnd = sorted[i-1].Offset + sorted[i-1].Length) is rewritten assorted[i-1].Length > sorted[i].Offset - sorted[i-1].Offset, safe because the slice is sorted in ascending offset order.Test plan
golangci-lintclean🤖 Generated with Claude Code