Skip to content

fix WAL enum decoding for corrupt records #350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
justrach wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix WAL enum decoding for corrupt records #350

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
579238c
fix WAL enum decoding for corrupt records
justrach Mar 23, 2026
500feff
Merge remote-tracking branch 'origin/main' into fix/226-wal-replay-en…
justrach Mar 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 46 additions & 2 deletions src/graph/wal.zig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -278,7 +278,7 @@ fn parseRecord(data: []const u8, start: usize, op_byte: u8) !ParseResult {
const id = try readU32(data, &pos);
const path = try readBytesView(data, &pos);
if (pos >= data.len) return error.Truncated;
const language: Language = @enumFromInt(data[pos]);
const language: Language = std.meta.intToEnum(Language, data[pos]) catch return error.InvalidOp;
pos += 1;
const last_modified = try readI64(data, &pos);
if (pos + 32 > data.len) return error.Truncated;
Expand Down Expand Up @@ -316,7 +316,7 @@ fn parseRecord(data: []const u8, start: usize, op_byte: u8) !ParseResult {
const src = try readU64(data, &pos);
const dst = try readU64(data, &pos);
if (pos >= data.len) return error.Truncated;
const kind: EdgeKind = @enumFromInt(data[pos]);
const kind: EdgeKind = std.meta.intToEnum(EdgeKind, data[pos]) catch return error.InvalidOp;
pos += 1;
if (pos + 4 > data.len) return error.Truncated;
const weight: f32 = @bitCast(data[pos..][0..4].*);
Expand Down Expand Up @@ -797,3 +797,47 @@ test "WAL single byte of garbage produces zero records" {

try std.testing.expectEqual(@as(usize, 0), result.records_applied);
}

test "WAL invalid language byte stops replay without trapping" {
var w = WalWriter.init(std.testing.allocator);
defer w.deinit();

try w.logAddFile(.{
.id = 1,
.path = "a.zig",
.language = .zig,
.last_modified = 1,
.hash = [_]u8{0xAB} ** 32,
});

var corrupted = try std.testing.allocator.dupe(u8, w.data());
defer std.testing.allocator.free(corrupted);
const language_offset = 1 + 4 + 4 + "a.zig".len;
corrupted[language_offset] = 0xFF;

var g = CodeGraph.init(std.testing.allocator);
defer g.deinit();
var result = try replay(corrupted, &g, std.testing.allocator);
defer result.deinit();

try std.testing.expectEqual(@as(usize, 0), result.records_applied);
}

test "WAL invalid edge kind byte stops replay without trapping" {
var w = WalWriter.init(std.testing.allocator);
defer w.deinit();

try w.logAddEdge(.{ .src = 1, .dst = 2, .kind = .calls, .weight = 1.0 });

var corrupted = try std.testing.allocator.dupe(u8, w.data());
defer std.testing.allocator.free(corrupted);
const kind_offset = 1 + 8 + 8;
corrupted[kind_offset] = 0xFF;

var g = CodeGraph.init(std.testing.allocator);
defer g.deinit();
var result = try replay(corrupted, &g, std.testing.allocator);
defer result.deinit();

try std.testing.expectEqual(@as(usize, 0), result.records_applied);
}
Loading