fix: config.zig — strip inline # comments from TOML values (#428)#433
Open
fix: config.zig — strip inline # comments from TOML values (#428)#433
Conversation
…ed strings Adds stripInlineComment() that handles three cases: - unquoted values: strip from first # preceded by whitespace - quoted values: preserve # inside quotes - bare hash (no preceding space): treated as part of the value Fixes #428 Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
stripInlineComment()to the minimal TOML parserprimary = claude # notenow correctly parse as"claude"primary = "claude # not a comment"are preserved#without preceding space (e.g.color#abc) is not treated as a commentTest plan
zig test src/config.zig— all 7 tests pass (4 existing + 3 new)inline comments are stripped from unquoted valuesinline comments are NOT stripped inside quoted valueshash without preceding space is not a commentFixes #428
Made with Cursor