fix: dispatch.zig — surface OOM and spawn failures instead of silent fallback (#430)#435
Open
fix: dispatch.zig — surface OOM and spawn failures instead of silent fallback (#430)#435
Conversation
- OOM in system prompt concatenation now logs via std.debug.print instead of silently dropping the system prompt - dispatch() writes an error sentinel to out when backend produces no output, so the MCP caller knows the run failed - Added 2 unit tests for the sentinel logic Fixes #430 Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
[dispatch] OOM: system prompt droppedviastd.debug.printinstead of silently degradingdispatch()checks if backend produced any output; writes a sentinel error message ifoutis unchanged, so MCP callers know the run failedTest plan
zig ast-check src/runtime/dispatch.zigpassesempty output sentinel is written when backend produces nothingnon-empty output does not get sentinel appendedBackend.labeltest unchangedFixes #430
Made with Cursor