add support to redact (hide) some of the labels in the metrics#157
Open
gandalfmagic wants to merge 3 commits intojustwatchcom:masterfrom
Open
add support to redact (hide) some of the labels in the metrics#157gandalfmagic wants to merge 3 commits intojustwatchcom:masterfrom
gandalfmagic wants to merge 3 commits intojustwatchcom:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We use sql_exporter in our environments, but for us the following labels can be sensitive data:
With this patch we add a global configuration entry
redacted_labels, which specifies which labels can be omitted from metrics.