Extract database name from query instead of path for mssql#163
Merged
dewey merged 4 commits intojustwatchcom:masterfrom Sep 22, 2025
Merged
Extract database name from query instead of path for mssql#163dewey merged 4 commits intojustwatchcom:masterfrom
dewey merged 4 commits intojustwatchcom:masterfrom
Conversation
Author
|
Fixes #162 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit modifies the SQL Server (MSSQL) connection handling in job.go to extract the database name from the query parameters instead of the URL path. This change likely improves the parsing of SQL Server connection strings by using the more reliable database= query parameter rather than relying on the path component for database name extraction.