fix(ui): respect navigation-bar inset on full-screen routes - #15
Merged
Conversation
Under enableEdgeToEdge() content draws behind the system bars. Several
full-screen routes leaked the bottom navigation bar:
- DeckDetailScreen: the custom Scaffold bottomBar ("Start studying") is
not auto-inset by Material3 and, being fixed, couldn't scroll into
view — it rendered behind the nav bar. Apply navigationBars inset.
- Settings / PublishDeck / FriendProfile: applied statusBars only, so
bottom-most actions could sit under the nav bar on 3-button devices.
Switch to systemBars to inset top and bottom, matching Onboarding and
Study.
Pager tabs (ShortNavigationBar consumes the nav inset) and topBar-only
Scaffolds (auto bottom inset via innerPadding) were already correct.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Under
enableEdgeToEdge()content draws behind the system bars, and each full-screen route must consume the bars itself. Several screens were cut off by the system navigation bar — most visibly Deck Detail, whose "Start studying" button was drawn behind the nav bar.Changes
DeckDetailScreen— the customScaffoldbottomBar(the study button) is not auto-inset by Material3, and being a fixed bar it couldn't scroll into view. AddedWindowInsets.navigationBarspadding. (the reported bug)SettingsScreen,PublishDeckScreen,FriendProfileScreen— these full-screen routes appliedstatusBarsonly, so bottom-most actions could sit under the nav bar on 3-button devices. Switched tosystemBars(top + bottom), matchingOnboardingScreen/StudySessionScreen.Already correct (verified, untouched)
ShortNavigationBar, which natively consumes the nav inset;statusBarsfor the top is correct.ScaffoldwithtopBaronly → bottom nav inset auto-applied viainnerPadding.Testing
./gradlew :composeApp:compileDebugKotlinpasses. Not yet visually verified on an emulator.🤖 Generated with Claude Code