fix: make the iOS app build, and close the parity gaps with Android

[jvsena42]

Summary

The iOS app did not compile. Tab in GapsScreen/SettingsScreen was only the first error the compiler reported — fixing it exposed 136 compile errors across 19 of the 39 Swift files, plus a link failure. The Swift layer had been written against a Kotlin/Native API that does not exist and had never been built against the shared module.

It went unnoticed because .github/workflows/ci.yml ran only on ubuntu-latest and never compiled Swift. Three broken String(localized:) keys shipped the same way.

This PR gets iOS building, closes the layout and preview gaps against Android, makes share-to-Worn actually work, and adds a macOS CI job so the next Swift break is caught.

The shared KMP layer was already at parity: all five expect/actual pairs have real iOS actuals, iosModule binds the same 11 slots as androidModule, and the on-device AI feature from 4922618 is fully wired. No stubs or TODOs in shared/src/iosMain.

One behaviour change worth reviewing

OnDeviceAiService built its image prompt from Attachment and ImageAttachmentContent. Neither exists — the iOS 26.5 .swiftinterface shows FoundationModels is text-only (the only Attachment symbols are feedback-logging). On-device photo analysis is therefore not possible on iOS; generate() now reports that clearly when handed an image. Gap recommendations are text-only and still run on device. Android is unaffected, since Gemini Nano does accept an ImagePart.

Changes

Kotlin/Native interop (the bulk of the 136 errors)

• Sealed interfaces export as flat Objective-C classes, so WardrobeIntent.ClearSelection is WardrobeIntentClearSelection — 36 sites across five Intent/Effect hierarchies plus OnDeviceAiAvailability
• init* functions get a do prefix to avoid clashing with ObjC init: initKoin() is doInitKoin()
• isUsable is an extension property, exported as a static on OnDeviceAiAvailabilityKt, not a member
• Koin's own types are not in the framework's exported API and never reach the generated header, so koin.get(objCClass:) could never work — added a typed object KoinHelper in iosMain exposing one property per dependency
• StateFlow exports as a non-generic protocol whose value is Any?, so FlowAdapter's element type is named explicitly at each call site; effects are a plain Flow, which FlowAdapter cannot take, so added EffectAdapter alongside it

Name collisions and drift

• Category collides with objc_category from objc/runtime.h and Material with SwiftUI.Material; both qualified as Shared.*
• Kotlin default arguments do not reach ObjC, so preview constructors now pass every parameter (ClothingItem.subcategory/fit/material, WardrobeState.isAiAvailable, OutfitState.allClothingItems)
• WornColors declared Identifiable conformance without importing Shared; the five ViewModel wrappers used withAnimation without importing SwiftUI
• toKotlinByteArray/toData were declared in three files — consolidated into Services/ByteArrayBridge.swift
• TryItScreen's tablet layout called an errorContent helper that was never written; extracted from the phone layout so both share one definition

Linking

• Shared is a static framework, so SQLDelight's sqliter dependency leaves its sqlite3_* symbols to the app — added -lsqlite3

Parity with Android

• Extracted GapsContent and SettingsContent so both screens adapt to iPad (24pt/32pt content padding, matching GapsScreen.kt:142 and SettingsScreen.kt:174), and so their previews render without Koin
• @Environment(\.horizontalSizeClass) read from an App struct is never populated, so isCompact was permanently false and the bottom bar stayed expanded on iPhone too — moved the tab host into a RootView
• Painted the app background behind the safe areas; they were falling through to the window's black (Android gets this from enableEdgeToEdge())
• Fixed three String(localized:) calls referencing keys that do not exist, which rendered as raw key text in both locales
• Adopted the unused deleteConfirmationAlert modifier at all four inline .alert sites, matching Android's shared DeleteConfirmationDialog.kt and giving the buttons the delete_dialog_cancel/delete_dialog_confirm identifiers the journeys drive
• iPad previews now use traits: .portrait per CLAUDE.md, replacing .landscapeLeft and the #Preview-ignored .previewDevice; added the missing pairs to ClothingCard, CategoryFilterChips and WornBottomBar
• Bottom bar: widened the compact layout (both platforms, per the update-both rule) and gave each tab an equal slot so long translations stay inside it — pt-BR "COMBINAÇÕES" was spilling over the adjacent pill

Share extension

• CODE_SIGN_ENTITLEMENTS was set on no target, so group.com.github.worn was never applied and SharedPhotoInbox.consume() always read a nil container
• Added the WornShareExtension target, its synchronized group, an Embed Foundation Extensions phase and the dependency plumbing. No Kotlin framework phase, per SETUP.md — the appex binary is 128 KB against the app's 28 MB, confirming it does not link the static framework
• GENERATE_INFOPLIST_FILE is YES, not NO as SETUP.md suggested: with NO the checked-in plist supplies no CFBundleIdentifier and the build fails embedded-binary validation
• Rewrote SETUP.md to describe the committed target instead of manual Xcode steps

CI and cleanup

• Added a macos-latest job building the iosApp scheme, which also builds and embeds the extension
• Committed a shared xcscheme; Xcode autocreates schemes into gitignored xcuserdata, so xcodebuild -scheme iosApp had nothing to resolve on a fresh checkout
• Removed the untouched KMP template: ContentView.swift was still compiled into the app but never referenced, and was the only consumer of Greeting.kt and transitively Platform.kt and both actuals

Test plan

./gradlew detekt :shared:allTests :composeApp:assembleDebug

# the CI-equivalent iOS build — fails on main
xcodebuild build -project iosApp/iosApp.xcodeproj -scheme iosApp \
  -destination 'generic/platform=iOS Simulator' \
  CODE_SIGNING_ALLOWED=NO CODE_SIGNING_REQUIRED=NO

Run on iPhone 16 and iPad Pro 11-inch in portrait:

• All five tabs load; background is cream edge to edge, no black safe areas
• iPhone: bar spans the width. iPad: centred 480pt pill
• Settings → Your Profile shows "Tall and slim"/"Big and tall", not body_type_tall_slim; a slim-fit item's detail sheet shows "Slim", not fit_slim_fit
• Gaps and Settings use 32pt side padding on iPad, matching Wardrobe and Outfits

Re-run in pt-BR (xcrun simctl launch <device> com.github.worn.Worn -AppleLanguages "(pt-BR)") — the bottom bar labels must stay inside their own slots.

Share handoff, without needing the share sheet:

GROUP=$(xcrun simctl get_app_container booted com.github.worn.Worn group.com.github.worn)
cp some.jpg "$GROUP/pending_share.jpg"
xcrun simctl launch booted com.github.worn.Worn

Worn should open on Try It with the photo loaded, and pending_share.jpg should be gone.

Xcode canvas: GapsScreen.swift and SettingsScreen.swift previews must render without initKoin() having run.

Verified

detekt, :shared:allTests and :composeApp:assembleDebug pass. iOS builds via the exact CI invocation. Ran on iPhone 16 (iOS 18.6), iPad Pro 11-inch and iPhone 17 Pro (iOS 26.5, exercising the weak-linked FoundationModels) in both en and pt-BR. App Group container resolves and the handoff file is consumed and deleted.

Not verified

Two checks need interactive taps that simctl cannot drive, and are left for review on a device:

• The real Photos share sheet listing Worn, and openHostApp() bringing the app forward. The credential matrix is documented in iosApp/WornShareExtension/SETUP.md
• The Settings on-device-AI toggle subtitle across Available/Downloadable/Unavailable(reason:)

TryItScreen still instantiates its stateful screen in previews, so its canvas needs Koin — left as a follow-up to keep this diff bounded.

Checklist

• ./gradlew detekt passes
• Tested on Android
• Tested on iOS
• Updated documentation (if applicable)

🤖 Generated with Claude Code