fix: refresh gap suggestions from the live wardrobe and actually save from them

[jvsena42]

Summary

Fixes #42 — "added a polo shirt but it is still displayed in the suggestions".

Two independent defects each reproduced that report:

1. Suggestions never refreshed. GapsViewModel computed the list once in init (and on the LoadGaps intent, which is wired only to the error-state Retry button), reading the wardrobe through the one-shot getAll() rather than observeAll(). The Gaps screen stays alive on both platforms — HorizontalPager on Android, @StateObject on iOS — so adding an item on the Wardrobe tab left the suggestion on screen until the ViewModel happened to be recreated. That is the "updated later" in the issue thread.
2. The Gaps "Add to Wardrobe" button discarded the item. Both platforms opened AddItemSheet with onSave = { _,_,_,_,_,_,_,_ -> dismiss } — no repository call, no photo written. A user who tapped the Polo shirt suggestion, filled the form and saved got nothing stored, so the suggestion legitimately stayed.

Suggestions are now derived from the live wardrobe rather than fetched-and-cached, and the ownership filter applies to AI recommendations as well as the local capsule fallback — so both lists re-filter the instant an item is added or deleted anywhere, without spending another Claude request. The AI list itself is still fetched only on init, on an AI-availability change, or on an explicit retry.

Changes

• excludingOwned extracted into GapRecommendation.kt and applied to both the AI list and the capsule fallback. Matches on Subcategory alone (mappedCategory disagrees by design) and keeps recommendations the AI left untagged, since a null subcategory has nothing to compare against.
• GapsViewModel restructured — combine(observeAll().catch { … }, _uiState).stateIn(viewModelScope, Eagerly), mirroring WardrobeViewModel. A wardrobe emission never triggers an AI call; a test pins the call count.
• Gaps save wired through GapsIntent.AddItem on GapsViewModel, which already had WardrobeRepository injected. Resolving a second WardrobeViewModel was rejected: it is a Koin factoryOf, so on iOS that would leak an uncancelled observeAll() collector per screen, and on Android it would share the Wardrobe tab's instance and close its sheet too.
• New prefillItem param on AddItemSheet (both platforms). Seeding through existingItem put the sheet in editing mode — "Edit item", "Save changes", AI badge hidden — for an item that did not exist yet.
• Effects are now collected on the Gaps screen on both platforms; previously GapsEffect.ShowError was dropped on the floor everywhere.
• AI failure message defaulted — a null Throwable.message left state.error null, which rendered the "your wardrobe looks complete" screen on a failure.
• iOS: clear selectedSubcategory when the category changes, mirroring Android. Without it an iOS user could save a BOTTOM item carrying Subcategory.POLO, which permanently suppressed the Polo shirt suggestion — the same symptom as Check fallback suggestions logic #42 from a different cause. Reset in the picker action rather than .onChange(of: selectedCategory), which would also fire while seeding the form and wipe a legitimate prefill.
• Test fakes extended: FakeWardrobeRepository.addItem silently dropped subcategory/fit/material, and getGapRecommendations was hardcoded to an empty list — neither the regression test nor the no-extra-AI-call assertion was expressible before.
• GapRecommendationParsingTest re-implemented the filter expression inline instead of calling production code, so it would have kept passing if production stopped filtering; moved to GapRecommendationFilterTest in commonTest.
• Docs: CLAUDE.md now requires branching off main, and the documented single-test command is corrected — :shared:allTests is an aggregate task that rejects --tests.

Test plan

• ./gradlew :shared:allTests — 160 tests green, including 18 new in GapsViewModelTest and 7 in GapRecommendationFilterTest.
• Key regression tests: adding an item to the wardrobe removes its suggestion without any intent, adding an item re-filters the AI list without a new AI call, adding the recommended item removes it from the suggestions.
• ./gradlew :composeApp:assembleDebug and ./gradlew detekt clean.
• Manual (needs a real photo, so out of the journeys): add a polo on the Wardrobe tab, swipe to Gaps — "Polo shirt" is gone with no retry; delete it — it comes back.
• New journey journeys/gaps-add-suggestion.xml covers the prefill sheet reading "Add new item" / "Save to wardrobe" rather than the editing copy, stopping before the photo. Existing journeys/gaps-common-suggestions.xml is untouched and must still pass.

Not verified: the Swift changes are not compile-checked — linkDebugFrameworkIosSimulatorArm64 is skipped on Linux and there is no Xcode in this environment. The Kotlin iosSimulatorArm64 compilation does pass, so the exported GapsIntentAddItem / GapsEffectItemAdded symbols exist, but the iOS app needs a build on macOS before merge.

Related

Filed #51 while working on this: Subcategory.HOODIE sits under Category.TOP while the capsule hoodie gap is Category.OUTERWEAR, so the pre-filled sheet shows a subcategory its own dropdown cannot re-select. Not blocking — the filter matches on subcategory alone precisely because those two disagree.

Checklist

• ./gradlew detekt passes
• Tested on Android
• Tested on iOS
• Updated documentation (if applicable)

🤖 Generated with Claude Code