mQV issues correlated#3
Open
willconboy wants to merge 10 commits into
Open
Conversation
Correlating utilities w/ pmp on QV.nlogo and perceived-utility additions to multi-QV-with-polling.nlogo
pushed here before pulling from master
jzkelter
requested changes
Nov 11, 2020
| ] | ||
| ] | ||
| ) | ||
| if correlate-issues != 0 [ |
Owner
There was a problem hiding this comment.
make correlate-issue a boolean instead of 0 or 1 and call it correlate-issues?
| let curr-issue 0 | ||
| ; Adding in a negative correlationas well (in other words, the issues selected will have a negative correlation with the first issue), this is less relevant from an analytic perspective, but I left it in just in case. | ||
| repeat correlate-n-issues [ | ||
| ifelse correlate-issues > 0 [ |
Owner
There was a problem hiding this comment.
I don't like the name "correlate-issues" for the issue correlation. It sounds like a command. Maybe call it issues-correlation
| let temp-utilities (list) | ||
| let curr-issue 0 | ||
| ; Adding in a negative correlationas well (in other words, the issues selected will have a negative correlation with the first issue), this is less relevant from an analytic perspective, but I left it in just in case. | ||
| repeat correlate-n-issues [ |
Owner
There was a problem hiding this comment.
In the correlate-n-issues slider on the interface, you can make the maximum equal to number-of-issues so that visually there is an indication that there should never be more issues correlated than there are total issues
| ; Adding in a negative correlationas well (in other words, the issues selected will have a negative correlation with the first issue), this is less relevant from an analytic perspective, but I left it in just in case. | ||
| repeat correlate-n-issues [ | ||
| ifelse correlate-issues > 0 [ | ||
| set temp-utilities fput ((correlate-issues * first-issue-utility) + ((1 - correlate-issues) * item curr-issue utilities)) temp-utilities |
Owner
There was a problem hiding this comment.
get rid of the ifelse block and just do (1 - abs issues-correlation)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.