Integrate uv_loop with CFRunLoop#52
Draft
kabiroberai wants to merge 24 commits intomainfrom
Draft
Conversation
himself65
reviewed
Jul 6, 2025
himself65
left a comment
himself65
left a comment
There was a problem hiding this comment.
there is napi_get_uv_event_loop API you can get
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #51 (comment)
I'm not 100% satisfied with this yet because it makes re-entrant
uv_runcalls, which is officially unsupported, though it does seem to work in the rudimentary cases I've tested.