Rewrite the SkinManager to avoid race conditions & Mojang ratelimit#392
Open
OptimisticDeving wants to merge 10 commits intokaboomserver:masterfrom
Open
Rewrite the SkinManager to avoid race conditions & Mojang ratelimit#392OptimisticDeving wants to merge 10 commits intokaboomserver:masterfrom
OptimisticDeving wants to merge 10 commits intokaboomserver:masterfrom
Conversation
This method will also return true if the proxy is configured as online mode, whereas the other one did not and presumably always applied skins when behind a proxy.
Also removes the per-player cooldown since a maximum of 2 requests is sent per second. UUID request results are also cached.
amyavi
approved these changes
Mar 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also removes the per-player cooldown since a maximum of 2 requests is sent per second. UUID request results are also cached.