Skip to content

Test label translation - #105

Open
kadeshar wants to merge 2 commits into
label-translation-improvementfrom
test-label-translation
Open

Test label translation#105
kadeshar wants to merge 2 commits into
label-translation-improvementfrom
test-label-translation

Conversation

@kadeshar

@kadeshar kadeshar commented Jul 4, 2026

Copy link
Copy Markdown
Owner

Pull Request Description

Feature Evaluation

  • Describe the minimum logic required to achieve the intended behavior.
  • Describe the processing cost when this logic executes across many bots.

How to Test the Changes

Impact Assessment

  • Does this change increase per-bot/per-tick processing or risk scaling poorly with thousands of bots?

      • No, not at all
      • Minimal impact (explain below)
      • Moderate impact (explain below)
  • Does this change modify default bot behavior?

      • No
      • Yes (explain why)
  • Does this change add new decision branches or increase maintenance complexity?

      • No
      • Yes (explain below)

AI Assistance

Was AI assistance used while working on this change?

    • No
    • Yes (explain below)

Code Provenance / Attribution

Was any code in this PR copied or adapted from a sister / upstream project (e.g. CMaNGOS playerbots,
MaNGOS, another module)?

    • No, all code in this PR is original
    • Yes (name the project and the original author(s) below)

Final Checklist

    • Stability is not compromised.
    • Performance impact is understood, tested, and acceptable.
    • Added logic complexity is justified and explained.
    • Any new bot dialogue lines are translated.
    • Any code ported/adapted from another project is attributed (project + author(s), Co-authored-by: trailer + in-file note).
    • New source files use the GPLv2 header.
    • Documentation updated if needed (Conf comments, WiKi commands).
    • New and modified files do not introduce new compiler warnings.

Notes for Reviewers

Copilot AI review requested due to automatic review settings July 4, 2026 18:44

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR modifies the playerbot SQL update for BiS/autogear localization strings, seemingly to adjust or validate translated labels/messages used by the /p autogear bis command text system.

Changes:

  • Adds an additional ai_playerbot_texts row for bis_applying_msg.
  • Adds a new INSERT INTO ai_playerbot_texts block for bis_autogear_unavailable_error near the end of the file.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +160 to 169

(1779, 'bis_applying_msg', 'Applying BiS gear', 0, 0,
'BiS 장비를 적용합니다.',
'Application de l''équipement BiS.',
'Wende BiS-Ausrüstung an.',
'正在装备BiS装备。',
'正在裝備BiS裝備。',
'Aplicando equipo BiS.',
'Aplicando equipo BiS.',
'Применяю BiS-снаряжение.'),
Comment on lines +181 to +195
INSERT INTO `ai_playerbot_texts`
(`id`, `name`, `text`, `say_type`, `reply_type`,
`text_loc1`, `text_loc2`, `text_loc3`, `text_loc4`,
`text_loc5`, `text_loc6`, `text_loc7`, `text_loc8`)
VALUES
(1767, 'bis_autogear_unavailable_error',
'autogear command is not allowed, please check the configuration.', 0, 0,
'자동 장비 명령이 허용되지 않습니다. 설정을 확인하세요.',
'La commande autogear n''est pas autorisée, veuillez vérifier la configuration.',
'Der autogear-Befehl ist nicht erlaubt, bitte überprüfe die Konfiguration.',
'自动装备命令未启用,请检查配置。',
'自動裝備指令未啟用,請檢查設定。',
'El comando autogear no está permitido, por favor revisa la configuración.',
'El comando autogear no está permitido, por favor revisa la configuración.',
'Команда autogear не разрешена, проверьте конфигурацию.');
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants