-
Notifications
You must be signed in to change notification settings - Fork 425
feat: configurable UI headline and subtitle via environment variables #1434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
optimus-fulcria
wants to merge
3
commits into
kagent-dev:main
Choose a base branch
from
optimus-fulcria:feat/configurable-ui-text
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
1413a18
feat: add configurable UI headline and subtitle via environment varia…
optimus-fulcria 7dce822
fix: ensure runtime env var reading for configurable headline
optimus-fulcria 00705e2
fix: use runtime env vars instead of NEXT_PUBLIC_ build-time vars
optimus-fulcria File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,13 +1,14 @@ | ||
| "use client"; | ||
| import { use } from "react"; | ||
| import ChatInterface from "@/components/chat/ChatInterface"; | ||
|
|
||
| export default function ChatPageView({ params }: { params: Promise<{ name: string; namespace: string; chatId: string }> }) { | ||
| const { name, namespace, chatId } = use(params); | ||
| export const dynamic = "force-dynamic"; | ||
|
|
||
| export default async function ChatPageView({ params }: { params: Promise<{ name: string; namespace: string; chatId: string }> }) { | ||
| const { name, namespace, chatId } = await params; | ||
|
|
||
| return <ChatInterface | ||
| selectedAgentName={name} | ||
| selectedNamespace={namespace} | ||
| sessionId={chatId} | ||
| headline={process.env.KAGENT_UI_HEADLINE} | ||
| />; | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,8 +1,10 @@ | ||
| import ChatInterface from "@/components/chat/ChatInterface"; | ||
| import { use } from 'react'; | ||
|
|
||
| export const dynamic = "force-dynamic"; | ||
|
|
||
| // This page component receives props (like params) from the Layout | ||
| export default function ChatAgentPage({ params }: { params: Promise<{ name: string, namespace: string }> }) { | ||
| const { name, namespace } = use(params); | ||
| return <ChatInterface selectedAgentName={name} selectedNamespace={namespace} />; | ||
| } | ||
| export default async function ChatAgentPage({ params }: { params: Promise<{ name: string, namespace: string }> }) { | ||
| const { name, namespace } = await params; | ||
| const headline = process.env.KAGENT_UI_HEADLINE; | ||
| return <ChatInterface selectedAgentName={name} selectedNamespace={namespace} headline={headline} />; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,8 @@ | ||
| import AgentList from "@/components/AgentList"; | ||
| export default function AgentListPage() { | ||
| return <AgentList />; | ||
|
|
||
| export const dynamic = "force-dynamic"; | ||
|
|
||
| export default async function AgentListPage() { | ||
| const subtitle = process.env.KAGENT_UI_SUBTITLE; | ||
| return <AgentList subtitle={subtitle} />; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,8 @@ | ||
| import AgentList from "@/components/AgentList"; | ||
|
|
||
| export const dynamic = "force-dynamic"; | ||
|
|
||
| export default async function AgentListPage() { | ||
| return <AgentList />; | ||
| const subtitle = process.env.KAGENT_UI_SUBTITLE; | ||
| return <AgentList subtitle={subtitle} />; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
process.env.NEXT_PUBLIC_HEADLINEis being read inside a Client Component page (this file has "use client"), which means the value is inlined at build time and won’t reflect runtime env var changes. To achieve runtime configurability, read the env var in a Server Component (remove "use client" from this page or move the env read into the server layout/page) and pass it toChatInterfaceas a prop (and force dynamic rendering for the route or layout).