-
Notifications
You must be signed in to change notification settings - Fork 426
Ability to open sub-agent sessions in chat #1466
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dobesv
wants to merge
2
commits into
kagent-dev:main
Choose a base branch
from
dobesv:sub-agent-session-view
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+404
−17
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
62 changes: 62 additions & 0 deletions
62
python/packages/kagent-adk/src/kagent/adk/_session_linking_plugin.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,62 @@ | ||
| from __future__ import annotations | ||
|
|
||
| import logging | ||
| from typing import Any | ||
|
|
||
| from google.adk.plugins.base_plugin import BasePlugin | ||
| from google.adk.tools.agent_tool import AgentTool | ||
| from google.adk.tools.base_tool import BaseTool | ||
| from google.adk.tools.tool_context import ToolContext | ||
|
|
||
| from kagent.core.a2a import ( | ||
| KAGENT_METADATA_KEY_CALLER_APP_NAME, | ||
| KAGENT_METADATA_KEY_CALLER_SESSION_ID, | ||
| KAGENT_METADATA_KEY_CALLER_TOOL_CALL_ID, | ||
| get_kagent_metadata_key, | ||
| ) | ||
|
|
||
| logger = logging.getLogger("kagent_adk." + __name__) | ||
|
|
||
|
|
||
| class SessionLinkingPlugin(BasePlugin): | ||
| """A plugin that propagates parent session metadata to child agents. | ||
|
|
||
| This plugin intercepts tool calls to AgentTool and injects the parent's | ||
| session_id and tool_call_id into the session state. | ||
| Because AgentTool clones the current session state when creating a child | ||
| session, these values are automatically propagated to the sub-agent and | ||
| eventually to the remote A2A task metadata. | ||
| """ | ||
|
|
||
| def __init__(self, name: str = "session_linking"): | ||
| super().__init__(name) | ||
|
|
||
| async def before_tool_callback( | ||
| self, | ||
| *, | ||
| tool: BaseTool, | ||
| tool_args: dict[str, Any], | ||
| tool_context: ToolContext, | ||
| ) -> None: | ||
| """Inject parent metadata into the state before an AgentTool runs.""" | ||
| # We only need to do this for tools that spin up sub-sessions (AgentTools) | ||
| if isinstance(tool, AgentTool): | ||
| invocation_context = tool_context._invocation_context | ||
| if not invocation_context: | ||
| logger.warning( | ||
| "No invocation context found in tool_context for tool %s. Cannot link sessions.", | ||
| tool.name, | ||
| ) | ||
| return | ||
|
|
||
| # Parent metadata keys. We use a prefix that is NOT filtered out by | ||
| # AgentTool (which typically filters '_adk'). | ||
| parent_metadata = { | ||
| get_kagent_metadata_key(KAGENT_METADATA_KEY_CALLER_APP_NAME): invocation_context.app_name, | ||
| get_kagent_metadata_key(KAGENT_METADATA_KEY_CALLER_SESSION_ID): invocation_context.session.id, | ||
| get_kagent_metadata_key(KAGENT_METADATA_KEY_CALLER_TOOL_CALL_ID): tool_context.function_call_id, | ||
| } | ||
|
|
||
| # Update the current session state. This state is then cloned by | ||
| # the AgentTool.run_async method to create the child session. | ||
| tool_context.state.update(parent_metadata) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.