chore: upgrade Go from 1.25.7 to 1.26.1#1477
Open
jsonmp-k8 wants to merge 6 commits intokagent-dev:mainfrom
Open
chore: upgrade Go from 1.25.7 to 1.26.1#1477jsonmp-k8 wants to merge 6 commits intokagent-dev:mainfrom
jsonmp-k8 wants to merge 6 commits intokagent-dev:mainfrom
Conversation
Update Go version across go.work, all go.mod files, and CI workflow. Go 1.26.1 includes security fixes, the Green Tea GC enabled by default, and reduced cgo overhead. Signed-off-by: Jaison Paul <paul.jaison@gmail.com>
One job still used actions/setup-go@v4 while the other two used v5. Align to v5 for consistent behavior and Go 1.26 cache support. Signed-off-by: Jaison Paul <paul.jaison@gmail.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Upgrades the repository’s Go toolchain baseline across the workspace and modules, and updates CI to run with the new Go minor version.
Changes:
- Bump
godirectives from1.25.7to1.26.1in the workspace and all Go modules. - Refresh
go.sumfiles to include additional*.go.modchecksum entries. - Update GitHub Actions CI to use Go
1.26.
Reviewed changes
Copilot reviewed 5 out of 7 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| go/go.work | Update workspace Go version directive to 1.26.1. |
| go/core/go.mod | Update module Go version directive to 1.26.1. |
| go/api/go.mod | Update module Go version directive to 1.26.1. |
| go/adk/go.mod | Update module Go version directive to 1.26.1. |
| go/api/go.sum | Add missing *.go.mod checksum entries after tidy. |
| go/adk/go.sum | Add missing *.go.mod checksum entries after tidy. |
| .github/workflows/ci.yaml | Bump CI Go version from 1.25 to 1.26 across jobs. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Align the golangci-lint config with the Go 1.26 upgrade so type-checking and parsing match the CI toolchain. Signed-off-by: Jaison Paul <paul.jaison@gmail.com>
golangci-lint v2.8.0 was built with Go 1.25 and fails with: "the Go language version (go1.25) used to build golangci-lint is lower than the targeted Go version (1.26)" v2.11.3 is built with Go 1.26 and resolves this. Signed-off-by: Jaison Paul <paul.jaison@gmail.com>
Replace ptr.To(x) with new(x) per Go 1.26 modernize linter rules, remove unused ptrTo helper, and delete redundant loop variable copy. Signed-off-by: Jaison Paul <paul.jaison@gmail.com>
Signed-off-by: Jaison Paul <paul.jaison@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
go.work,go/adk/go.mod,go/api/go.mod,go/core/go.mod)actions/setup-goto v5 for all CI jobs (one job was still on v4)modernizelinternewexprviolations: replaceptr.To(x)withnew(x)across 18 Go files (Go 1.26 language feature)ptrTogeneric helper inhack/makeagentconfig/main.gocopyloopvarviolation: remove redundant loop variable copy inhttpserver/handlers/modelconfig.goTest plan
go vetpasses on all modulesgo mod tidyclean on all modulesgolangci-lint runpasses with 0 issues