feat: Add CI/CD and documentation polish (Phase 4)#382
Draft
Alan-Cha wants to merge 1 commit into
Draft
Conversation
Complete documentation and CI/CD integration for Vault pattern. This completes Phase 4 (final phase) of the Vault pattern implementation: - Add vault-fetcher to CI/CD build matrix - Update root CLAUDE.md with vault-fetcher documentation - Create comprehensive stacked PR workflow guide Files modified: - .github/workflows/build.yaml — Add vault-fetcher to build matrix - CLAUDE.md — Document vault-fetcher in container images table Files added: - STACKED_PR_WORKFLOW.md (300+ lines) — Complete guide for stacked PR workflow and cascade rebase process Documentation includes: - Current stack structure - Creating stacked PRs (manual and gh-stack) - Critical rebase process when earlier branches change - Handling conflicts - Merging strategy - Common scenarios and troubleshooting - Best practices This document is essential for maintaining the stacked PR workflow, especially when review feedback requires changes to earlier branches. Ref: #vault-pattern Stacked on: PR #TBD (Phase 3) Signed-off-by: Alan Cha <Alan.cha1@ibm.com>
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Phase 4 (FINAL) of the Vault pattern: CI/CD integration and documentation polish.
Stacked on: #381 (Phase 3 - Webhook integration)
This PR completes the Vault pattern implementation by adding CI/CD automation and comprehensive workflow documentation.
What This Adds
CI/CD Integration
.github/workflows/build.yamlghcr.io/kagenti/kagenti-extensions/vault-fetcheron releasesDocumentation Updates
STACKED_PR_WORKFLOW.md — Critical Documentation
This new document is essential for maintaining the stacked PR workflow, especially when earlier PRs receive review feedback.
Key sections:
Why This Matters
Example scenario covered:
feat/vault-integrationbranchRebase cascade commands:
```bash
git checkout feat/vault-fetcher-cli && git rebase feat/vault-integration && git push --force-with-lease
git checkout feat/vault-webhook && git rebase feat/vault-fetcher-cli && git push --force-with-lease
git checkout feat/vault-docs-polish && git rebase feat/vault-webhook && git push --force-with-lease
```
Files Modified
.github/workflows/build.yaml— Add vault-fetcher to matrixCLAUDE.md— Document vault-fetcher imageFiles Added
STACKED_PR_WORKFLOW.md(300+ lines) — Complete stacked PR guideTotal: ~454 lines added
Stacked PR Structure (FINAL)
```
main
└─> #379 (Phase 1: authlib/vault library)
└─> #380 (Phase 2: vault-fetcher CLI)
└─> #381 (Phase 3: Webhook integration)
└─> THIS PR (Phase 4: CI/CD & docs) ← FINAL
```
Completion Status
✅ Phase 1: authlib/vault library
✅ Phase 2: vault-fetcher CLI tool
✅ Phase 3: Webhook integration docs
✅ Phase 4: CI/CD + workflow docs
🎉 Vault pattern implementation is COMPLETE with this PR!
Merge Strategy
After all reviews are complete:
gh pr edit 380 --base main)Or: Squash Phases 2-4 together and merge as one final PR after Phase 1 merges.
Review Notes
Focus review on:
Testing
After merge, vault-fetcher will build on next tag push:
```bash
git tag v0.2.0
git push origin v0.2.0
Triggers build.yaml workflow
Pushes ghcr.io/kagenti/kagenti-extensions/vault-fetcher:v0.2.0
```
Assisted-By: Claude (Anthropic AI) noreply@anthropic.com