Embedded new tab page to fix Chrome breaking the default on search change#16
Open
jkowskib wants to merge 11 commits intokagisearch:mainfrom
Open
Embedded new tab page to fix Chrome breaking the default on search change#16jkowskib wants to merge 11 commits intokagisearch:mainfrom
jkowskib wants to merge 11 commits intokagisearch:mainfrom
Conversation
This reverts commit 938dd53.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a response to both my own experience and something mentioned in [https://github.com//issues/13](this issue).
For Chrome, when the Kagi extension is installed it disables Google search as expected. However because of some oversite in Chrome or by design, this messes up the default
chrome://newtabpage and completely removes all of the search bar and logo leaving behind a broken looking webpage that contains only the quick links. Here is an example I did to show it.To remedy this I have created an embedded offline page in the
newtabfolder, its simple for now as this is just a proposal to see how everyone feels about this. I modified the manifest to include achrome_url_overridesthat will set the/newtab/index.htmlto overwrite the default new tab. I would have simply made it load the Kagi website, but after more consideration, its probably better to keep it offline so the new tab page does not break if the user looses internet. Hence making a embedded page. Here is a sample of it.Basically a copy of the Kagi search page. I used all icons and graphics from the official Kagi page to ensure there is no issue of who owns the icons and such. Personally I would like this, the broken Chrome page is strange to look at. But if its out of scope I understand.