Conversation
|
Total coverage threshold (65%) satisfied: PASS |
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferences |
8e5c218 to
44339c4
Compare
rueidis tries CLUSTER topology discovery by default, which fails with EOF on standalone Valkey instances. Add WithStandalone() SDK option and Standalone field in Valkey store Config to set ForceSingleClient.
44339c4 to
32c1dd5
Compare
|
@greptile |
Greptile SummaryFixed EOF error when connecting to standalone Valkey by adding
The implementation is clean and follows existing patterns. Consider whether the Redis backend ( Confidence Score: 5/5
Important Files Changed
Last reviewed commit: 32c1dd5 |
Problem
rueidis tries CLUSTER topology discovery by default. Standalone Valkey (e.g. fsqr-valkey) returns error on CLUSTER command, causing EOF on connect.
Fix
Add
ForceSingleClient: trueto rueidis ClientOption — skips cluster discovery for standalone instances.