feat: show title+season info at playerControl top#24
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughSummary by CodeRabbit
WalkthroughChangesNow Playing Label
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@krissedout fair enough, i'll try a few variations and get back. I tried at the bottom but it didnt look great. What about this? Top centered.
|
|
That seems much better! I think we can do it like that, you could experiment more if you want to see how it would look if for example it was bigger (the same height as the back button), I don't know how that would look but if you think it looks bad you can just do this variant! Also it looks like it has a border even though the rest of the elements don't so just make sure to remove that border. |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/app/src/pages/player/Player.svelte`:
- Around line 1433-1440: The now-playing label’s native title tooltip is
unreachable because its parent has pointer-events-none. Update the span
containing title={nowPlayingLabel} to re-enable pointer events while keeping the
outer controls wrapper non-interactive, so truncated text can trigger the
tooltip.
- Around line 1438-1439: Update the title pill span’s max-width utility in the
player UI to use a container- or viewport-relative constraint instead of the
fixed max-w-[640px]. Preserve the existing truncation and styling while ensuring
long titles cannot overflow narrow phones or embedded players.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 01571bde-186f-4dc3-a10c-e4c354ae52aa
📒 Files selected for processing (1)
packages/app/src/pages/player/Player.svelte



Many times Id like to know what season/episode im on, but currently there's no way to see it.
I can change the design however you'd like, granted this change is acceptable.