Fix if-tag parsing when 'and/or' appear inside string literals #238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open

petersgecko wants to merge 1 commit into kalimatas:master from pedros80:fix-if-logical-operator-in-strings

+138 −39

Open

Fix if-tag parsing when 'and/or' appear inside string literals #238

Fix if-tag parsing when 'and/or' appear inside string literals

Annotations

10 warnings

src/Liquid/AbstractBlock.php#L228

Escaped Mutant for Mutator "ConcatOperandRemoval": @@ @@ case 'else': throw new ParseException($this->blockName() . " does not expect else tag"); case 'end': - throw new ParseException("'end' is not a valid delimiter for " . $this->blockName() . " tags. Use " . $this->blockDelimiter()); + throw new ParseException("'end' is not a valid delimiter for " . $this->blockName() . " tags. Use "); default: throw new ParseException("Unknown tag $tag"); }

src/Liquid/AbstractBlock.php#L228

Escaped Mutant for Mutator "Concat": @@ @@ case 'else': throw new ParseException($this->blockName() . " does not expect else tag"); case 'end': - throw new ParseException("'end' is not a valid delimiter for " . $this->blockName() . " tags. Use " . $this->blockDelimiter()); + throw new ParseException("'end' is not a valid delimiter for " . $this->blockName() . $this->blockDelimiter() . " tags. Use "); default: throw new ParseException("Unknown tag $tag"); }

src/Liquid/AbstractBlock.php#L228

Escaped Mutant for Mutator "ConcatOperandRemoval": @@ @@ case 'else': throw new ParseException($this->blockName() . " does not expect else tag"); case 'end': - throw new ParseException("'end' is not a valid delimiter for " . $this->blockName() . " tags. Use " . $this->blockDelimiter()); + throw new ParseException("'end' is not a valid delimiter for " . $this->blockName() . $this->blockDelimiter()); default: throw new ParseException("Unknown tag $tag"); }

src/Liquid/AbstractBlock.php#L228

Escaped Mutant for Mutator "Concat": @@ @@ case 'else': throw new ParseException($this->blockName() . " does not expect else tag"); case 'end': - throw new ParseException("'end' is not a valid delimiter for " . $this->blockName() . " tags. Use " . $this->blockDelimiter()); + throw new ParseException("'end' is not a valid delimiter for " . " tags. Use " . $this->blockName() . $this->blockDelimiter()); default: throw new ParseException("Unknown tag $tag"); }

src/Liquid/AbstractBlock.php#L228

Escaped Mutant for Mutator "ConcatOperandRemoval": @@ @@ case 'else': throw new ParseException($this->blockName() . " does not expect else tag"); case 'end': - throw new ParseException("'end' is not a valid delimiter for " . $this->blockName() . " tags. Use " . $this->blockDelimiter()); + throw new ParseException("'end' is not a valid delimiter for " . " tags. Use " . $this->blockDelimiter()); default: throw new ParseException("Unknown tag $tag"); }

src/Liquid/AbstractBlock.php#L228

Escaped Mutant for Mutator "ConcatOperandRemoval": @@ @@ case 'else': throw new ParseException($this->blockName() . " does not expect else tag"); case 'end': - throw new ParseException("'end' is not a valid delimiter for " . $this->blockName() . " tags. Use " . $this->blockDelimiter()); + throw new ParseException($this->blockName() . " tags. Use " . $this->blockDelimiter()); default: throw new ParseException("Unknown tag $tag"); }

src/Liquid/AbstractBlock.php#L228

Escaped Mutant for Mutator "Concat": @@ @@ case 'else': throw new ParseException($this->blockName() . " does not expect else tag"); case 'end': - throw new ParseException("'end' is not a valid delimiter for " . $this->blockName() . " tags. Use " . $this->blockDelimiter()); + throw new ParseException($this->blockName() . "'end' is not a valid delimiter for " . " tags. Use " . $this->blockDelimiter()); default: throw new ParseException("Unknown tag $tag"); }

src/Liquid/AbstractBlock.php#L226

Escaped Mutant for Mutator "ConcatOperandRemoval": @@ @@ { switch ($tag) { case 'else': - throw new ParseException($this->blockName() . " does not expect else tag"); + throw new ParseException(" does not expect else tag"); case 'end': throw new ParseException("'end' is not a valid delimiter for " . $this->blockName() . " tags. Use " . $this->blockDelimiter()); default:

src/Liquid/AbstractBlock.php#L226

Escaped Mutant for Mutator "Concat": @@ @@ { switch ($tag) { case 'else': - throw new ParseException($this->blockName() . " does not expect else tag"); + throw new ParseException(" does not expect else tag" . $this->blockName()); case 'end': throw new ParseException("'end' is not a valid delimiter for " . $this->blockName() . " tags. Use " . $this->blockDelimiter()); default:

src/Liquid/AbstractBlock.php#L208

Escaped Mutant for Mutator "ProtectedVisibility": @@ @@ /** * An action to execute when the end tag is reached */ - protected function endTag() + private function endTag() { // Do nothing by default }

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix if-tag parsing when 'and/or' appear inside string literals #238

Uh oh!

Fix if-tag parsing when 'and/or' appear inside string literals #238

Uh oh!

Annotations

The logs for this run have expired and are no longer available.

Re-running jobs...

Fix if-tag parsing when 'and/or' appear inside string literals #238

Are you sure you want to change the base?