Remove svElement event listeners on $destroy#138
Open
alejandroiglesias wants to merge 1 commit intokamilkp:masterfrom
Open
Remove svElement event listeners on $destroy#138alejandroiglesias wants to merge 1 commit intokamilkp:masterfrom
alejandroiglesias wants to merge 1 commit intokamilkp:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a
Cannot read property 'forEach' of undefinedthrow that happens if one of the sortable elements has a child with amouseupevent handler that callsEvent.stopPropagation(). In that case, thesvElementmousedown/touchstartevent handler fires, registering themousemove/touchmoveevent handler on thedocumentElement, but there's nomouseupbecause it was stopped from propagating. This event handler keeps being registered even if the component doesn't exist anymore.The fix involves de-registering the
mousemove/touchmoveevent handler on thesvElement's$destroyevent, and it's pretty low-risk.