(fixed)Using sv-helper would hide the visibility of original element#61
Open
sankalplakhina wants to merge 1 commit intokamilkp:masterfrom
Open
(fixed)Using sv-helper would hide the visibility of original element#61sankalplakhina wants to merge 1 commit intokamilkp:masterfrom
sankalplakhina wants to merge 1 commit intokamilkp:masterfrom
Conversation
…forever. Was not removing class .sv-visibility-hidden on move execution completion
Owner
|
"This branch has conflicts that must be resolved" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On using sv-helper directive, the original item in repeat array gets a .sv-visibility-hidden class. On drop of this item to new position, this class was not removed due to which the original item stays dissapeared and seems like to be deleted or gone from the DOM.
Fixed this by removing the class on move execution completion.