Merged
Conversation
Updated ResolveRelativeUrl to correctly combine the documentation scope's RootUrl with relative asset paths, ensuring proper resolution regardless of whether RootUrl is absolute or relative. Increased test coverage.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request improves asset URL resolution logic in the documentation routing system and enhances test coverage to verify correct behavior in various scenarios. The main changes involve refining how asset paths are resolved for file-based topics, updating related tests to reflect new path handling, and incrementing the project and test adapter versions.
Asset URL Resolution Improvements
ContextAwareUrlTransformerto more robustly handle asset paths relative to the topic's directory, ensuring correct handling for both absolute and relative URLs.Test Coverage and Accuracy
ContextAwareUrlTransformerTests.csto cover scenarios where assets are located in different folders, the same folder, or do not exist, including new tests for assets in the same folder and adjustments to scope paths and expected URL results.Dependency and Version Updates
Kampute.DocToolkitfrom 2.2.0 to 2.2.1 to reflect the new changes.NUnit3TestAdapterdependency in the test project to version 6.1.0 for improved test support.