🔧 Use Node.js 22 and bump i18next-cli#1280
Open
LitoMore wants to merge 1 commit intokando-menu:mainfrom
Open
Conversation
Contributor
|
Thanks for looking into this. However, missing translations are now inserted as "" in the translation files which makes them disappear in the GUI. Is it possible to fallback to the English strings again? Also, it's not very nice that we now have to list the locales in the i18next.config.ts. This way, whenever someone adds a new language on weblate, we need to update this list manually. Is there some way around this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
i18next-parsertoi18next-cliThe legacy
i18next-parserpackage blocked us from upgrading the Node.js version because it does not support Node.js 22 or later. The i18next team has deprecated thei18next-parserand recommends users migrate toi18next-cli. I migrated it toi18next-climanually and made some cleanup (comments, configuration) using AI (Opus 4.6).Those translation files have been changed because the
i18next-clisupports sorting keys. I just used its default configurations. Sorting keys can make the content in translation files consistent, so I kept it. Please let me know if you have any thoughts.