Skip to content

Use title window property on Hyprland #1333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Schneegans wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Use title window property on Hyprland #1333

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion docs/changelog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,9 @@ This changelog follows the rules of [Keep a Changelog](http://keepachangelog.com

### :wrench: Changed

- **:collision: The Hyprland backend** now uses the `title` property of windows in addition to the `initialTitle` property. With this change, you can now make menus which only show up for windows with dynamic titles (e.g. a terminal showing the current directory in the title, or a browser showing the current page title). It considers the window's name now to be **_initialTitle_ - _title_**. If you used window-name conditions in your menus, you may have to update them to match the new window name format.
- **The GNOME Wayland backend** is now used if `XDG_CURRENT_DESKTOP` contains ":gnome" instead of checking for a hard-coded list of GNOME versions. This should make it more robust and compatible with more desktop environments which identify themselves as GNOME-compatible. Thanks to [@radmorecameron](https://github.com/radmorecameron) for this contribution!
- The icon-picker dialog will now remember the last selected icon theme if you closed it by accident. Before, it would always reset to the currently selected icon theme which could be quite annoying. Thanks to [@Haruto-works333](https://github.com/Haruto-works333) for this contribution!
- The GNOME Wayland backend is now used if `XDG_CURRENT_DESKTOP` contains ":gnome" instead of checking for a hard-coded list of GNOME versions. This should make it more robust and compatible with more desktop environments which identify themselves as GNOME-compatible. Thanks to [@radmorecameron](https://github.com/radmorecameron) for this contribution!
- Upgraded many dependencies to their latest versions. This includes an upgrade to Electron 40 which uses Wayland natively now on Linux. Feel free to report any issues you encounter!
- Pinned all GitHub Actions to specific commit SHAs to increase the security of the build process. Thanks to [@pgoslatara](https://github.com/pgoslatara) for this contribution!

Expand Down
3 changes: 2 additions & 1 deletion src/main/backends/linux/hyprland/backend.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,8 @@ for more information.
]);

return {
windowName: activewindow['initialTitle'] || '',
windowName:
(activewindow['initialTitle'] || '') + ' - ' + (activewindow['title'] || ''),
appName: activewindow['initialClass'] || '',
pointerX: cursorpos['x'],
pointerY: cursorpos['y'],
Expand Down
Loading