Register Rdkafka::Consumer finalizer#841
Merged
mensfeld merged 1 commit intokarafka:masterfrom Mar 24, 2026
Merged
Conversation
mensfeld
added a commit
that referenced
this pull request
Mar 24, 2026
- Remove dead `Admin#finalizer` instance method that captures `self` and could never work as a GC finalizer (matching Consumer cleanup from #841) - Replace `after` block with `around`/`ensure` in admin specs to clear leaked handles from the registry, preventing a single test timeout or broker error from cascading failures to all subsequent tests - Update CHANGELOG with PR #841 attribution (jturkel)
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both
Rdkafka::AdminandRdkafka::Producerregister finalizers in their constructor to ensure the native Kafka handle is closed when the object is GCed to prevent segfaults if the object hasn't been properly closed. This PR adds similar functionality toRdkafka::Consumer.Rdkafka::Consumer#closealready unregisters the finalizer so I'm assuming the missing finalizer registration was unintentional. I also removed theRdkafka::Consumer#finalizermethod which will never actually get invoked by the Ruby VM.