fix(mobile): prevent crash with certain bookmark attributes#2654
Draft
fix(mobile): prevent crash with certain bookmark attributes#2654
Conversation
… handling - In crawlerWorker, check content-type from response headers before downloading the full file body. Return null early (with a warning log) for unsupported content types like image/svg+xml, avoiding wasted bandwidth and changing the log from error to warn level. - In mobile BookmarkCard, filter out external SVG URLs before passing to expo-image, which does not support SVG and crashes on Android when an SVG imageUrl is encountered. Fixes #2596 Co-authored-by: Mohamed Bassem <MohamedBassem@users.noreply.github.com>
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2596
Changes
crawlerWorker, check content-type from response headers before downloading the full file body. Return null early (with a warning log) for unsupported content types likeimage/svg+xml, avoiding wasted bandwidth and changing the log from error to warn level.BookmarkCard, filter out external SVG URLs before passing toexpo-image, which does not support SVG and crashes on Android.Generated with Claude Code