Conversation
| about.Type = PluginType.General; | ||
|
|
||
| about.MinInterfaceVersion = 30; | ||
| about.MinInterfaceVersion = 60; |
There was a problem hiding this comment.
What's the reason for this change? Also with such a high setting you won't be able to enable this plugin.
There was a problem hiding this comment.
What's the reason for this change? Also with such a high setting you won't be able to enable this plugin.
To be honest, I don't know how did this happen.
It's not even on the .cs file I have on my PC. This is obviously incorrect and will cause the plugin not to work. Probably caused when uploading it to github,
| customApiUrlLabel.Location = new Point(0, 40); | ||
| customApiUrlLabel.Text = "Custom API URL:"; | ||
| customApiUrlTextBox = new System.Windows.Forms.TextBox(); | ||
| customApiUrlTextBox.Location = new Point(customApiUrlLabel.Width + 35, 40); |
There was a problem hiding this comment.
The spacing is incorrect. The textbox is not aligned correctly with the label and its bottom border is cut.
| ElementState.ElementStateDefault, | ||
| ElementComponent.ComponentForeground)); | ||
| customApiUrlTextBox.BorderStyle = BorderStyle.FixedSingle; | ||
| customApiUrlTextBox.Text = Properties.Settings.Default.customApiUrl; |
There was a problem hiding this comment.
There's a possibility, that a user will accidentally edit this URL, which will break his scrobbling in a non-obvious way. This textbox should be non-editable by default, and there should be a checkbox labeled accordingly, that will make this field editable. A value for an API endpoint from this textbox should be used only when this checkbox is checked, otherwise LB URL should be used.
2 participants
Works with Maloja using /apis/listenbrainz/1/submit-listens