Adding Margins to Library#7
Open
TomGeshury wants to merge 2 commits intokareemaly:masterfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addition allows dynamic adding of margins by offsetting width that it normally removes. By doing this, this change allows more flexibility for users to style activeStyles.
Problem attempted to solve:
I haven't found any bugs except with the current implementation of border, the library will not work. However, I still believe this is needed because the current implementation of border is very hard to manage i.e. when the desired outcome was to alter the width of it as well as center that border.
Let me know if you have any thoughts