You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Here are some key observations to aid the review process:
⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
🧪 No relevant tests
🔒 Security concerns
Supply chain risk: This PR updates bundled executable binaries via new Git LFS OIDs. Verify provenance (download/build source), confirm hashes against trusted release artifacts, and ensure the binaries are not tampered with before shipping. Consider documenting the upstream URLs/commit/tag used and the expected checksums for each architecture.
Validate that the new Git LFS object points to the intended rclone v1.73.0 ARM binary (correct upstream source, expected build flags, and runnable on target devices). Also sanity-check the notably smaller binary size versus the previous version to ensure it wasn’t accidentally compressed/stripped incorrectly or replaced with an unexpected artifact.
oid sha256:cf10cc846b307dbeacdbea91a4a1c57bba8af13e1828558af0eb8871eb31893e
size 70189240
Confirm the ARM64 artifact is actually the correct architecture build and executes properly (e.g., rclone version reports v1.73.0), since this change only updates LFS pointers and does not inherently guarantee runtime compatibility on-device.
oid sha256:f15f7056ced525da911a8277935760c9df349baacb6929401d5058791f540461
size 70451384
Ensure the version string update is consistent with the release being shipped and that other version metadata (e.g., versionCode policy) does not require a bump for distribution/update semantics in your packaging ecosystem.
Bump versionCode when updating bundled binaries so module managers can detect and deliver the update reliably. Keeping versionCode unchanged may cause devices to skip installing this new rclone build.
Why: The PR updates the bundled rclone binaries (and version=) but leaves versionCode=115 unchanged, which can prevent some module managers from recognizing the update. This is a reasonable release-management improvement, though not strictly a functional bug in the code itself.
Low
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
Automated Binary Update
This PR updates the bundled binaries:
v1.72.1→v1.73.0Architectures Updated
Changelog
See rclone releases for details.
This PR was automatically created by the update-binaries workflow.
PR Type
Enhancement
Description
Update bundled
rclonebinaries to v1.73.0Refresh Git LFS pointers for all architectures
Bump module
versionstring accordinglyDiagram Walkthrough
File Walkthrough
rclone
Update arm rclone Git LFS pointercommon/binary/arm/rclone
oidto new binarysizefor artifactrclone
Update arm64 rclone Git LFS pointercommon/binary/arm64/rclone
oidto new binarysizefor artifactrclone
Update x64 rclone Git LFS pointercommon/binary/x64/rclone
oidto new binarysizefor artifactrclone
Update x86 rclone Git LFS pointercommon/binary/x86/rclone
oidto new binarysizefor artifactmodule.prop
Bump module version to rclone v1.73.0module.prop
versionfrom rclone v1.72.1 to v1.73.0