rm spec issues re Object.create(null) & __proto__#22
rm spec issues re Object.create(null) & __proto__#22marsmining wants to merge 4 commits intokarma-runner:masterfrom
Conversation
the previous code used the idiom of `Object.create(null)` to use an object like a hash or cache, and leveraged the prototype chain as a type of cache miss failover. there is some js spec wierdness and changes around node 0.12 surrounding the existence of `__proto__` when using `Object.create(null)`. to eliminate this confusion i've added a function to replace the above so that the semantics are clear and consistent and we aren't using the non-standard `__proto__`.
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
|
I signed it! On Thu, Jun 18, 2015 at 10:45 AM, googlebot notifications@github.com
Brandon van Beekum |
|
CLAs look good, thanks! |
turn autowatch off, add karma-firefox-launcher to dev deps.
|
+1 |
3 participants
rm spec issues re Object.create(null) & proto
the previous code used the idiom of
Object.create(null)to use an object like a hash or cache, and leveraged the prototype chain as a type of cache miss failover. there is some js spec weirdness and changes around node 0.12 surrounding the existence of__proto__when usingObject.create(null).to eliminate this confusion i've added a function to replace the above so that the semantics are clear and consistent and we aren't using the non-standard
__proto__.also update npm dev deps to latest versions and added a missing jshintrc.