Skip to content

add browser websocket events dispatcher#46

Open
clifforum wants to merge 12 commits into
karthikv:masterfrom
orumhq:fe-events
Open

add browser websocket events dispatcher#46
clifforum wants to merge 12 commits into
karthikv:masterfrom
orumhq:fe-events

Conversation

@clifforum

Copy link
Copy Markdown

What changes did you make?

dispatched new events on the browser window. These events are related to the websockets events like connect, error, and the forced refresh.

Why did you make changes? What problem did this solve?

This will help teams that us the pkg to track browser websocket events for the own use cases.

Describe your testing strategy

added tests

Visual Design


Tasks

Check the boxes that are applicable.

  • I have a Jira ticket [PD-xxx] (replace the "xxx", and a bot will linkify it).
    • Make sure the ticket ID is in the title of the PR too (e.g. "[PD-xxx] My PR title").
  • I performed a self-review of my code with at least 3 comments on things that can be improved or fixed.
    • Please also add comments for reasoning/clarity or where tradeoffs are not obvious.
  • I changed authentication, security, or legal-related logic.
    • PRs that change any of these will need at least 2 reviewers. If you have any doubt about whether this applies to your PR, get a second reviewer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant